CSHARP-1378: Make BulkWrite enumerate requests argument only once #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
commented
Mar 19, 2024
| @@ -174,7 +174,7 @@ public class Acknowledged : BulkWriteResult<TDocument> | |||
|
|
|||
| // constructors | |||
| /// <summary> | |||
| /// Initializes a new instance of the <see cref="Acknowledged" /> class. | |||
| /// Initializes a new instance of the <see cref="BulkWriteResult{TDocument}.Acknowledged" /> class. | |||
There was a problem hiding this comment.
It does not related to the PR itself, but it fixes some warnings we got on build
| @@ -218,27 +218,30 @@ public override BulkWriteResult<TDocument> BulkWrite(IEnumerable<WriteModel<TDoc | |||
| public override BulkWriteResult<TDocument> BulkWrite(IClientSessionHandle session, IEnumerable<WriteModel<TDocument>> requests, BulkWriteOptions options, CancellationToken cancellationToken = default(CancellationToken)) | |||
| { | |||
| Ensure.IsNotNull(session, nameof(session)); | |||
| Ensure.IsNotNull(requests, nameof(requests)); | |||
| if (!requests.Any()) | |||
| Ensure.IsNotNull((object)requests, nameof(requests)); | |||
There was a problem hiding this comment.
This unnecessary cast to object needed to make code analysis happy, otherwise it says we might be doing multiple enumeration of the requests
|
|
||
| var result = async ? await subject.BulkWriteAsync(wrappedRequests) : subject.BulkWrite(wrappedRequests); | ||
|
|
||
| result.Should().NotBeNull(); |
There was a problem hiding this comment.
Basically we testing here is there were no exception, as wrappedRequests will throw on second attempt to enumerate.
BorisDog
requested changes
Mar 25, 2024
| @@ -234,7 +234,7 @@ internal static MongoBulkWriteException<TDocument> FromCore(MongoBulkWriteOperat | |||
|
|
|||
| return new MongoBulkWriteException<TDocument>( | |||
| ex.ConnectionId, | |||
| BulkWriteResult<TDocument>.FromCore(ex.Result, processedRequests), | |||
| BulkWriteResult<TDocument>.FromCore(ex.Result, processedRequests.ToList()), | |||
|
|
||
| namespace MongoDB.Driver.TestHelpers | ||
| { | ||
| public static class OnlyOnceEnumerable |
There was a problem hiding this comment.
Consider counting enumerations instead of throwing here.
BorisDog
approved these changes
Mar 29, 2024
| if (!requests.Any()) | ||
| Ensure.IsNotNull((object)requests, nameof(requests)); | ||
|
|
||
| var requestList = requests.ToArray(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.